Skip to content

feat: Use new ShareExternal icon for sharings section#3798

Merged
doubleface merged 1 commit intomasterfrom
feat/changeShareIcon
Apr 9, 2026
Merged

feat: Use new ShareExternal icon for sharings section#3798
doubleface merged 1 commit intomasterfrom
feat/changeShareIcon

Conversation

@doubleface
Copy link
Copy Markdown
Contributor

@doubleface doubleface commented Apr 9, 2026 •
edited by coderabbitai bot
Loading

image

Summary by CodeRabbit

  • Style
    • Updated the icon in the Sharings navigation menu item.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026 •
edited
Loading

Walkthrough

The pull request updates an icon import in the SharingsNavItem component. The ShareIcon import was replaced with ShareExternal from the cozy-ui library. This is a minimal change affecting only the icon import statement, with no modifications to component logic, rendering, query behavior, or the exported API.

Suggested reviewers

  • JF-Cozy
  • rezk2ll
  • zatteo
  • lethemanh
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing the ShareIcon with ShareExternal icon in the sharings section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/changeShareIcon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

codescene-delta-analysis[bot]
codescene-delta-analysis bot approved these changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

coderabbitai[bot]
coderabbitai bot reviewed Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/modules/navigation/SharingsNavItem.jsx (1)

5-5: Consider renaming the local icon alias for clarity.

Importing ShareExternal as ShareIcon works, but renaming the variable (e.g., ShareExternalIcon) would make intent clearer and reduce future confusion when scanning nav icon mappings.

✏️ Suggested rename 
-import ShareIcon from 'cozy-ui/transpiled/react/Icons/ShareExternal'
+import ShareExternalIcon from 'cozy-ui/transpiled/react/Icons/ShareExternal'
...
-      icon={<Icon icon={ShareIcon} />}
+      icon={<Icon icon={ShareExternalIcon} />}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/modules/navigation/SharingsNavItem.jsx` at line 5, Rename the imported
icon alias to make intent clearer: change the import of ShareExternal (currently
imported as ShareIcon) to ShareExternalIcon and update all local references
(e.g., any nav icon mappings or JSX usages in SharingsNavItem.jsx that reference
ShareIcon) to use ShareExternalIcon instead so the alias matches the original
component name and reduces ambiguity.
🤖 Prompt for all review comments with AI agents 
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/modules/navigation/SharingsNavItem.jsx`:
- Line 5: Rename the imported icon alias to make intent clearer: change the
import of ShareExternal (currently imported as ShareIcon) to ShareExternalIcon
and update all local references (e.g., any nav icon mappings or JSX usages in
SharingsNavItem.jsx that reference ShareIcon) to use ShareExternalIcon instead
so the alias matches the original component name and reduces ambiguity.
ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e2c53526-ee0e-49be-8b24-445dd7427704

📥 Commits

Reviewing files that changed from the base of the PR and between 396db7f and 42ac035.

📒 Files selected for processing (1)
  • src/modules/navigation/SharingsNavItem.jsx

@bundlemon
Copy link
Copy Markdown

bundlemon bot commented Apr 9, 2026

BundleMon

Files updated (1)
Status Path Size Limits
✅ static/js/cozy.(hash).js
 919.79KB (+351B +0.04%) -
Unchanged files (20)
Status Path Size Limits
✅ static/js/(chunkId).(hash).js
 1.17MB -
✅ public/static/js/(chunkId).(hash).js
 1.1MB -
✅ public/static/js/cozy.(hash).js
 782.19KB -
✅ (hash).js
 336.11KB -
✅ public/(hash).js
 336.11KB -
✅ services/qualificationMigration.js
 283.13KB -
✅ services/dacc.js
 262.86KB -
✅ static/js/main.(hash).js
 168.16KB -
✅ public/static/js/public.(hash).js
 141.81KB -
✅ public/static/js/lib-react.(hash).js
 43.88KB -
✅ static/js/lib-react.(hash).js
 43.88KB -
✅ public/static/css/cozy.(hash).css
 31.56KB -
✅ static/css/cozy.(hash).css
 31.56KB -
✅ public/static/js/lib-router.(hash).js
 21.86KB -
✅ static/js/lib-router.(hash).js
 21.86KB -
✅ static/css/main.(hash).css
 17.04KB -
✅ public/static/css/public.(hash).css
 6.76KB -
✅ manifest.webapp
 3.04KB -
✅ index.html
 700B -
✅ assets/manifest.json
 185B -

Total files change +357B +0.01%

Groups updated (1)
Status Path Size Limits
✅ **/*.js
 7.61MB (+361B 0%) -
Unchanged groups (2)
Status Path Size Limits
✅ **/*.{png,svg,ico}
 2.19MB -
✅ **/*.css
 120.14KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@doubleface doubleface merged commit fb82b03 into master Apr 9, 2026
6 checks passed
@doubleface doubleface deleted the feat/changeShareIcon branch April 9, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@rezk2ll rezk2ll rezk2ll approved these changes

@JF-Cozy JF-Cozy Awaiting requested review from JF-Cozy JF-Cozy is a code owner

@zatteo zatteo Awaiting requested review from zatteo zatteo is a code owner

@lethemanh lethemanh Awaiting requested review from lethemanh lethemanh is a code owner

+1 more reviewer

@codescene-delta-analysis codescene-delta-analysis[bot] codescene-delta-analysis[bot] approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doubleface @rezk2ll